Skip to content

Implement lockfile and symlink option #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2014
Merged

Implement lockfile and symlink option #140

merged 1 commit into from
Dec 4, 2014

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Oct 31, 2014

@ns-bot
Copy link

ns-bot commented Oct 31, 2014

Test FAILed.

@Fatme Fatme force-pushed the fatme/optimizations branch from bcddc99 to 1d9d0fc Compare October 31, 2014 08:05
@ns-bot
Copy link

ns-bot commented Oct 31, 2014

Test PASSed.

@Fatme Fatme changed the title Implement lockfile to allow parallel execution Implement lockfile and symlink option Oct 31, 2014
teobugslayer
teobugslayer reviewed Nov 11, 2014
View reviewed changes
lib/lockfile.ts
@@ -0,0 +1,41 @@
///<reference path=".d.ts"/>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"use strict";

@teobugslayer
Copy link
Contributor

I think this PR must be rebased after @rosen-vladimirov change of commands. Thoughts?

@Fatme Fatme force-pushed the fatme/optimizations branch from 1d9d0fc to 67fd3ec Compare November 12, 2014 08:19
@ns-bot
Copy link

ns-bot commented Nov 12, 2014

Test FAILed.

@Fatme Fatme force-pushed the fatme/optimizations branch from 67fd3ec to 40c6e43 Compare November 12, 2014 08:48
@ns-bot
Copy link

ns-bot commented Nov 12, 2014

Test FAILed.

@Fatme Fatme force-pushed the fatme/optimizations branch from 40c6e43 to b063865 Compare November 12, 2014 09:59
@ns-bot
Copy link

ns-bot commented Nov 12, 2014

Test PASSed.

@Fatme Fatme force-pushed the fatme/optimizations branch from b063865 to 92c900c Compare November 12, 2014 11:22
@ns-bot
Copy link

ns-bot commented Nov 12, 2014

Test PASSed.

@Fatme
Copy link
Contributor Author

Fatme commented Nov 12, 2014

run ci

@Fatme Fatme force-pushed the fatme/optimizations branch from 92c900c to 6d235ff Compare November 12, 2014 12:10
@ns-bot
Copy link

ns-bot commented Nov 12, 2014

Test PASSed.

@Fatme
Copy link
Contributor Author

Fatme commented Nov 26, 2014

run ci

@Fatme Fatme force-pushed the fatme/optimizations branch from 6d235ff to 3f4c35b Compare November 27, 2014 05:32
@ns-bot
Copy link

ns-bot commented Nov 27, 2014

Test FAILed.

@Fatme Fatme force-pushed the fatme/optimizations branch from 3f4c35b to 3b3a09f Compare November 27, 2014 05:37
@ns-bot
Copy link

ns-bot commented Nov 27, 2014

Test PASSed.

@Fatme Fatme force-pushed the fatme/optimizations branch from 3b3a09f to 6d235ff Compare November 27, 2014 07:13
@ns-bot
Copy link

ns-bot commented Nov 27, 2014

Test PASSed.

@Fatme
Copy link
Contributor Author

Fatme commented Nov 27, 2014

run ci

@Fatme Fatme force-pushed the fatme/optimizations branch from 6d235ff to c6923bb Compare November 27, 2014 10:25
@ns-bot
Copy link

ns-bot commented Nov 27, 2014

Test FAILed.

@Fatme Fatme force-pushed the fatme/optimizations branch from c6923bb to cbf2990 Compare November 27, 2014 10:31
@ns-bot
Copy link

ns-bot commented Nov 27, 2014

Test PASSed.

@Fatme Fatme force-pushed the fatme/optimizations branch from cbf2990 to 8d4b5ea Compare November 27, 2014 11:37
@ns-bot
Copy link

ns-bot commented Nov 27, 2014

Test FAILed.

1 similar comment
@ns-bot
Copy link

ns-bot commented Nov 27, 2014

Test FAILed.

@Fatme Fatme force-pushed the fatme/optimizations branch from 8d4b5ea to dd2c4a5 Compare November 27, 2014 12:41
@ns-bot
Copy link

ns-bot commented Nov 27, 2014

Test PASSed.

teobugslayer
teobugslayer reviewed Nov 27, 2014
View reviewed changes
lib/definitions/lockfile.d.ts
@@ -0,0 +1,15 @@
declare module "lockfile" {
export function lock(lockFilename: string, lockParams: ILockParams, callback: (err: Error) => void): void;
export function lockSync(lockFilename: string, lockParams: any): void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not ILockSyncParams but any?

@Fatme Fatme force-pushed the fatme/optimizations branch from dd2c4a5 to 44a2eed Compare November 27, 2014 14:10
@ns-bot
Copy link

ns-bot commented Nov 27, 2014

Test FAILed.

@Fatme Fatme force-pushed the fatme/optimizations branch from 44a2eed to b3a3eb8 Compare November 27, 2014 14:12
@ns-bot
Copy link

ns-bot commented Nov 27, 2014

Test FAILed.

@Fatme Fatme force-pushed the fatme/optimizations branch from b3a3eb8 to 1ad1e9a Compare November 27, 2014 14:14
@ns-bot
Copy link

ns-bot commented Nov 27, 2014

Test PASSed.

@Fatme Fatme force-pushed the fatme/optimizations branch from 1ad1e9a to a558472 Compare November 27, 2014 14:17
@ns-bot
Copy link

ns-bot commented Nov 27, 2014

Test PASSed.

@teobugslayer
Copy link
Contributor

👍 after a green build

@Fatme Fatme force-pushed the fatme/optimizations branch from a558472 to 76e86ce Compare November 27, 2014 14:38
@ns-bot
Copy link

ns-bot commented Nov 27, 2014

Test PASSed.

@Fatme Fatme force-pushed the fatme/optimizations branch from 76e86ce to 4891d78 Compare December 4, 2014 12:17
@ns-bot
Copy link

ns-bot commented Dec 4, 2014

Test PASSed.

@Fatme Fatme force-pushed the fatme/optimizations branch from 4891d78 to 156c047 Compare December 4, 2014 12:56
@ns-bot
Copy link

ns-bot commented Dec 4, 2014

Test PASSed.

Fatme pushed a commit that referenced this pull request Dec 4, 2014
Merge pull request #140 from NativeScript/fatme/optimizations
fa2f973 
Implement lockfile and symlink option
@Fatme Fatme merged commit fa2f973 into master Dec 4, 2014
@Fatme Fatme deleted the fatme/optimizations branch December 4, 2014 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fatme @ns-bot @teobugslayer